fix(dispatch-gates): a package-root vitest config or manifest edit derives check-console-intercept-disarm - #29556

Requested by Warren · project thread

Fixes #29353

Clause-②: no
Metadata-protocol: none

维护者速读

• 改了什么:check-console-intercept-disarm 在自己源码里声明它真正读的文件(各工作区包根的 package.json 与 vitest.config.*),dispatch-gates 据此把它派给改这些文件的卡;残差台账里它的两行随之删除。
• 为什么改:改包根 vitest 配置的卡,本地派生清单里没有这道门,只能等 CI 变红才知道(PR fix(server): budget counters hold their limit per key, count in a registered cache, and keep the in-process fallback bounded #29345 为此多跑了一轮)。
• 风险与回滚:只动工具脚本,不发布任何包;回滚即 revert 本 PR,派生回到原先的"无路径"状态。
• 先看:scripts/check-console-intercept-disarm.mjs(新声明与漂移检查)、scripts/pm/dispatch-gates.self-test.mjs(新增的实树钉子)、scripts/pm/dispatch-gates.data.mjs(删掉的两行)。
• 两分钟验证:node scripts/pm/dispatch-gates.mjs --commands --paths packages/services/service-sms/vitest.config.ts,预期输出里出现这道门的两条命令(主扫描与 --self-test)。
• 需要你做的:无,席位落地。

What changes

• Landing is the gate's own file, not only dispatch-gates.data.mjs. The order expected the data table; measured, the derivation reads a gate's population only from the gate's own source (the ROOT_DIR_WATCH_HINTS idiom), and dispatch-gates.data.mjs's header says it is "not a watch surface". So the producer-side fix is a declaration in scripts/check-console-intercept-disarm.mjs:
  • ROOT_DIR_WATCH_HINTS: one pair per workspace glob the gate parses, DIR/*/package.json and DIR/*/vitest.config.*. A glob in a non-final segment makes the derivation judge the hint as a pattern, one path segment per star, so a test file or a config below the package root is not covered.
  • A drift check: main() exits 1 when the declaration and the parsed pnpm-workspace.yaml globs disagree in either direction (watchHintDrift), and the gate's self-test holds the real tree to it plus both drift directions on fixtures. A literal array, as check:watch-hint-literal requires.
  • workspaceGlobs() is split out of workspacePackageDirs() with no change in behaviour; the three gates that import workspacePackageDirs are untouched.
• scripts/pm/dispatch-gates.data.mjs: the two ROOT_WALK_RESIDUE_LEDGER rows for the gate and its --self-test are retired, since both families have left the population. A note records why, beside the two earlier departures.
• scripts/pm/dispatch-gates.self-test.mjs: the card's acceptance, pinned against the live tree. Every package-root vitest config (80) and the manifest beside it places both invocations. A new package's config and manifest do too. No tracked test file under a package (6926) places either, and neither does a brand-new test file or a config below a package root.

Why

The rows stated the population correctly and drew the wrong conclusion: an EDITED package-root config moves the gate as surely as a new package does. Because the rows only exempted the gate from the whole-tree channel, no path derived it at all.

Tests

• Reverse check, with the gate file restored to 399df5bb (tree only, then restored from HEAD; git diff HEAD empty, blob hash matched): 80 of 80 package-root configs place neither invocation, and the test-file probe reads undetermined. With the fix, 0 of 80 are missed, and test files read silent.
• node scripts/check-console-intercept-disarm.mjs --self-test: self-test OK: 15 cases + real-tree population floor + watch-hint declaration. Scan: OK: 80 vitest-running package(s).

Verification

Final union on head 1b3ea66a (base 399df5bb): node scripts/pm/dispatch-gates.mjs --commands --repo objectstack-ai/objectstack derived 32 commands from the 3 changed paths; all 32 exit 0. --ran reconciliation: "32 derived famil(ies) accounted for — 32 run, 0 NOT-MEASURED". check:pm-dispatch-gates: "1945 cases pass" (fast tier). The first pass on a39185ba was 31 of 32: check:watch-hint-literal refused the Object.freeze wrapper, fixed in 1b3ea66a.

node scripts/check-closing-keyword-parity.mjs :: exit 0
node scripts/check-closing-keyword-parity.mjs --self-test :: exit 0
node scripts/check-comment-mask-corpus.mjs :: exit 0
node scripts/check-console-intercept-disarm.mjs :: exit 0
node scripts/check-console-intercept-disarm.mjs --self-test :: exit 0
node scripts/check-declaration-mirrors.mjs :: exit 0
node scripts/check-declaration-mirrors.mjs --self-test :: exit 0
node scripts/check-self-test-wired.mjs :: exit 0
node scripts/check-self-test-wired.mjs --self-test :: exit 0
node scripts/check-self-test-workflow-commands.mjs :: exit 0
node scripts/check-self-test-workflow-commands.mjs --self-test :: exit 0
node scripts/check-whole-set-label-write.mjs :: exit 0
node scripts/check-whole-set-label-write.mjs --self-test :: exit 0
node scripts/ci/plan-test-core-shards.mjs --self-test :: exit 0
node scripts/pm/bare-root-worklist.mjs --self-test :: exit 0
pnpm check:agent-test-spelling :: exit 0
pnpm check:bash32-floor :: exit 0
pnpm check:ci-filter-parity :: exit 0
pnpm check:cli-command-ids :: exit 0
pnpm check:cross-package-test-inputs :: exit 0
pnpm check:driver-memory-census :: exit 0
pnpm check:entry-guard :: exit 0
pnpm check:gitlink-declared :: exit 0
pnpm check:nul-bytes :: exit 0
pnpm check:parse-guard :: exit 0
pnpm check:pm-dispatch-gates :: exit 0
pnpm check:pnpm-filter-targets :: exit 0
pnpm check:pnpm-flag-spellings :: exit 0
pnpm check:ratchet-remedy-authority :: exit 0
pnpm check:refd-timer-probe :: exit 0
pnpm check:scripts-symbol-anchors :: exit 0
pnpm check:watch-hint-literal :: exit 0

Acceptance notes

• Not derivable, by construction: pnpm-workspace.yaml and the root vitest.preset.mts also move this gate, but neither carries a separator, so no spelling of either is a hint the derivation admits. Edits to those two files still learn of the gate from CI.
• Out of scope, reported to the seat and not fixed here: the gate's workspace parse stops at the first comment line inside the packages: list, so the four ui members below it are outside its population. Measured: 40 ui workspace packages run vitest and none sets the disarm. The declaration follows what the gate reads today, and its drift check will ask for the ui pairs on the day the parse reads them.

Human Minimum

• 1. Schemas start as Zod; packages/spec holds no runtime logic. (not touched)
• 2. Every name I added uses the casing for its kind.
• 3. No formatter ran; pnpm lint passes. (CI-owned run)
• 4. One issue, one branch off an up-to-date main, one pull request.
• 5. A change that publishes carries a changeset. (publishes nothing: scripts/** only, skip-changeset)
• 6. packages/spec touched: n/a.
• 7. No hand edits to content/docs/references/, packages/*/CHANGELOG.md or content/docs/releases/.
• 8. Title, body and comments are in English.
• The Before Submitting list in CONTRIBUTING.md is done.

🤖 Generated with Claude Code

https://claude.ai/code/session_01JQwxbXV6v4rbiDvvaaabhb

Generated by Claude Code